Remove puppeteer and switch to headless rendering to png #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbourSmith
approved these changes
Nov 28, 2024
|
Is the rasterization deterministic so it won't make the test fail when comparing the output? It should be, right? |
Yeah, I can't quite figure it out, except that perhaps it's related to devicePixelRatio causing the browser to oversample. |
I hope so, but mostly I wanted to (a) remove the dependency on pupeteer, and (b) support thumbnail generation. So now we should be able to say shape.png('foo') and be able to get a png of that view of shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.