fix: correctly get stdlib docs

julia-vscode · May 6, 2024 · eb9674c · eb9674c
1 parent eff1741
commit eb9674c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/src/SymbolServer.jl b/src/SymbolServer.jl
@@ -6,6 +6,10 @@ using Pkg, SHA
 using Base: UUID, Process
 import Sockets, UUIDs
 
+# this is required to get parsedocs to work on Julia 1.11 and newer, since the implementation
+# moved there
+using REPL
+
 include("faketypes.jl")
 include("symbols.jl")
 include("utils.jl")

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -184,21 +184,17 @@ end
 
     @test SymbolServer.stdlibs[:Base][:Sort][:sort] isa SymbolServer.FunctionStore
 
-    # FIXME: SymbolServer fails to index Base correctly during precompilation for some reason on 1.11
-    # I'm removing these tests so we can get a somewhat working release out.
-    if VERSION < v"1.11-"
-        @testset "symbol documentation" begin
-            @test !isempty(SymbolServer.stdlibs[:Base][:abs].doc)          # Function
-            if VERSION >= v"1.7"
-                @test !isempty(SymbolServer.stdlibs[:Core][:Pair].doc)         # DataType
-            else
-                @test !isempty(SymbolServer.stdlibs[:Base][:Pair].doc)         # DataType
-            end
-            @test !isempty(SymbolServer.stdlibs[:Base][:Libc].doc)         # Module
-            @test !isempty(SymbolServer.stdlibs[:Base][:LinRange].doc)     # UnionAll
-            @test !isempty(SymbolServer.stdlibs[:Base][:VecOrMat].doc)     # Union
-            @test occursin("Cint", SymbolServer.stdlibs[:Base][:Cint].doc) # Alias
+    @testset "symbol documentation" begin
+        @test !isempty(SymbolServer.stdlibs[:Base][:abs].doc)          # Function
+        if VERSION >= v"1.7"
+            @test !isempty(SymbolServer.stdlibs[:Core][:Pair].doc)         # DataType
+        else
+            @test !isempty(SymbolServer.stdlibs[:Base][:Pair].doc)         # DataType
         end
+        @test !isempty(SymbolServer.stdlibs[:Base][:Libc].doc)         # Module
+        @test !isempty(SymbolServer.stdlibs[:Base][:LinRange].doc)     # UnionAll
+        @test !isempty(SymbolServer.stdlibs[:Base][:VecOrMat].doc)     # Union
+        @test occursin("Cint", SymbolServer.stdlibs[:Base][:Cint].doc) # Alias
     end
 
     if VERSION >= v"1.1-"