Code style: Lint

Fix lint violations detected by hydromatic#200

src/main/java/net/hydromatic/morel/compile/Analyzer.java

@@ -199,9 +199,9 @@ public enum Use {
      * val g = fn ys => map (fn x => E) ys
      * }</pre>
      *
-     * no code is duplicated, but a small bounded amount of work is duplicated,
-     * because the closure {@code fn x => E} must be allocated each time
-     * {@code g} is called. */
+     * <p>no code is duplicated, but a small bounded amount of work is
+     * duplicated, because the closure {@code fn x => E} must be allocated
+     * each time {@code g} is called. */
     ONCE_UNSAFE,
 
     /** The binding may occur many times, including inside lambdas. */

src/main/java/net/hydromatic/morel/compile/Extents.java

@@ -101,7 +101,7 @@ private Extents() {}
    *   end
    * }</pre></blockquote>
    *
-   * we could deduce that "x" has extent "from e in edges group e.i",
+   * <p>we could deduce that "x" has extent "from e in edges group e.i",
    * "y" has extent "from e in edges group e.j"
    * ("from e in edges group e.i" is also valid),
    * "z" has extent "from e in edges group e.j",
@@ -371,3 +371,5 @@ static class ExtentFilter {
     }
   }
 }
+
+// End Extents.java

src/main/java/net/hydromatic/morel/eval/Prop.java

@@ -63,7 +63,7 @@ public enum Prop {
    * <a href="https://www.smlnj.org/doc/Compiler/pages/printcontrol.html">PRINTCONTROL signature</a>
    * of the Standard Basis Library.
    *
-   * Default is 12. */
+   * <p>Default is 12. */
   PRINT_LENGTH("printLength", Integer.class, 12),
 
   /** Boolean property "relationalize" is

src/main/java/net/hydromatic/morel/util/ImmutablePairList.java

@@ -106,3 +106,5 @@ static <T, U> ImmutablePairList<T, U> copyOf(
     return this;
   }
 }
+
+// End ImmutablePairList.java

src/main/java/net/hydromatic/morel/util/MapEntry.java

@@ -84,3 +84,5 @@ public MapEntry(T t, U u) {
     throw new UnsupportedOperationException("setValue");
   }
 }
+
+// End MapEntry.java

src/main/java/net/hydromatic/morel/util/Pair.java

@@ -188,7 +188,7 @@ public static <K, V> List<Pair<K, V>> zip(List<K> ks, List<V> vs) {
    * Converts two lists into a list of {@link Pair}s.
    *
    * <p>The length of the combined list is the lesser of the lengths of the
-   * source lists. But typically the source lists will be the same length.</p>
+   * source lists. But typically the source lists will be the same length.
    *
    * @param ks     Left list
    * @param vs     Right list
@@ -294,7 +294,7 @@ public static <K, V> void forEachIndexed(Map<K, V> map,
    * Converts two iterables into an iterable of {@link Pair}s.
    *
    * <p>The resulting iterator ends whenever the first of the input iterators
-   * ends. But typically the source iterators will be the same length.</p>
+   * ends. But typically the source iterators will be the same length.
    *
    * @param ks Left iterable
    * @param vs Right iterable
@@ -316,7 +316,7 @@ public static <K, V> Iterable<Pair<K, V>> zip(
    *
    * <p>The length of the combined list is the lesser of the lengths of the
    * source arrays. But typically the source arrays will be the same
-   * length.</p>
+   * length.
    *
    * @param ks Left array
    * @param vs Right array
@@ -422,7 +422,7 @@ public int size() {
   /**
    * Returns an iterator that iterates over (i, i + 1) pairs in an iterable.
    *
-   * <p>For example, {@code adjacents([3, 5, 7])} returns [(3, 5), (5, 7)].</p>
+   * <p>For example, {@code adjacents([3, 5, 7])} returns [(3, 5), (5, 7)].
    *
    * @param iterable Source collection
    * @param <T> Element type
@@ -442,7 +442,7 @@ public static <T> Iterable<Pair<T, T>> adjacents(final Iterable<T> iterable) {
    * Returns an iterator that iterates over (0, i) pairs in an iterable for
    * i &gt; 0.
    *
-   * <p>For example, {@code firstAnd([3, 5, 7])} returns [(3, 5), (3, 7)].</p>
+   * <p>For example, {@code firstAnd([3, 5, 7])} returns [(3, 5), (3, 7)].
    *
    * @param iterable Source collection
    * @param <T> Element type

src/main/java/net/hydromatic/morel/util/PairList.java

@@ -215,3 +215,5 @@ public PairList<T, U> build() {
     }
   }
 }
+
+// End PairList.java

src/test/java/net/hydromatic/morel/MainTest.java

@@ -1291,11 +1291,10 @@ public class MainTest {
     ml(ml).assertEval(is(7));
   }
 
-  /**
-   * <p>The algorithm is described in <a href="https://stackoverflow.com/questions/7883023/algorithm-for-type-checking-ml-like-pattern-matching">
-   *  Stack overflow</a> and in Lennart Augustsson's 1985 paper "Compiling
-   *  Pattern Matching".
-   */
+  /** The algorithm is described in
+   * <a href="https://stackoverflow.com/questions/7883023/algorithm-for-type-checking-ml-like-pattern-matching">
+   * Stack overflow</a> and in Lennart Augustsson's 1985 paper "Compiling
+   * Pattern Matching". */
   @Test void testMatchRedundant() {
     final String ml = "fun f x = case x > 0 of\n"
         + "   true => \"positive\"\n"

src/test/java/net/hydromatic/morel/PairListTest.java

@@ -425,3 +425,5 @@ private <T, U> void validate(PairList<T, U> pairList,
     validate(b3.build(), list);
   }
 }
+
+// End PairListTest.java