Skip to content

Conversation

mangelajo
Copy link
Member

@mangelajo mangelajo commented Oct 8, 2025

Add driver version and cli version requirements on reports Report exporter version to both server and clients

Summary by CodeRabbit

  • New Features
    • API responses now include software version details for exporters and drivers, improving visibility into running component versions.
    • Driver reports provide the minimum supported CLI version, helping users verify client compatibility before connecting.
    • Log streaming responses can include a source identifier, making it easier to distinguish log origins when viewing mixed streams.
    • Changes are backward compatible; existing integrations continue to work without modification.

Add driver version and cli version requirements on reports
Report exporter version to both server and clients
Copy link

coderabbitai bot commented Oct 8, 2025

Walkthrough

Adds new string fields for versioning across several messages and a minimum_cli_version to driver reports in the Jumpstarter v1 proto. Also adds an optional LogSource field to log streaming responses. No structural RPC changes; minor formatting tweak without semantic impact.

Changes

Cohort / File(s) Summary
Proto schema updates
proto/jumpstarter/v1/jumpstarter.proto
- RegisterRequest: add version (string)
- DriverInstanceReport: add version (string), minimum_cli_version (string)
- GetReportResponse: add version (string)
- LogStreamResponse: add optional source (LogSource)
- Minor non-semantic formatting adjustment

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant Server as Jumpstarter Service
  participant Driver as Driver Instance

  Client->>Server: RegisterRequest { version }
  Server-->>Client: RegisterResponse

  Driver->>Server: DriverInstanceReport { version, minimum_cli_version, ... }
  Server-->>Driver: Ack

  Client->>Server: GetReportRequest
  Server-->>Client: GetReportResponse { version, ... }

  Client->>Server: LogStreamRequest
  Server-->>Client: LogStreamResponse { source?, ... }
  note over Server,Client: Optional LogSource annotates log origin
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my feet in versioned delight,
New fields pop up—so shiny, so bright!
Logs whisper their source, clear as the moon,
Drivers declare the CLI tune.
With proto carrots neatly aligned,
I hop through schemas, peacefully signed.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly highlights that versioning details are being added to the exporter’s communication with both the controller and client, summarizing the main change of the pull request without unnecessary detail or ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch proto-component-versioning

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f8035c and 96cd113.

📒 Files selected for processing (1)
  • proto/jumpstarter/v1/jumpstarter.proto (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mangelajo mangelajo requested a review from kirkbrauer October 9, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant