Skip to content

fix(admin): handle xgrammar parser load failures #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stamsam wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

fix(admin): handle xgrammar parser load failures #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion omlx/admin/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,8 @@ async def list_grammar_parsers(is_admin: bool = Depends(require_admin)):
{"value": style, "label": style, "models": models}
for style, models in supported.items()
]
except ImportError:
except Exception as e:
logger.warning("xgrammar parser discovery unavailable: %s", e)
return []


Expand Down
15 changes: 15 additions & 0 deletions tests/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,3 +822,18 @@ def test_returns_empty_when_xgrammar_unavailable(self, client):
resp = client.get("/admin/api/grammar/parsers")
assert resp.status_code == 200
assert resp.json() == []

def test_returns_empty_when_xgrammar_native_binding_fails(self, client):
def raise_binding_error():
raise RuntimeError(
"Cannot find library: "
"libxgrammar_bindings.dylib, libxgrammar_bindings.so"
)

fake_xgrammar = SimpleNamespace(
get_builtin_structural_tag_supported_models=raise_binding_error
)
with patch.dict("sys.modules", {"xgrammar": fake_xgrammar}):
resp = client.get("/admin/api/grammar/parsers")
assert resp.status_code == 200
assert resp.json() == []