Skip to content

fix: catch TypeError when accessing think token properties #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightguarder wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −3
Open

fix: catch TypeError when accessing think token properties #1141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1627ac
fix: catch TypeError when accessing think token properties on non-thi…
nightguarder May 9, 2026
ed36c99
Merge branch 'main' into fix/think-token-typeerror-safety
nightguarder May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions omlx/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,7 +1707,10 @@ def _build_sampler_and_processors(
if think_end_ids:
from .api.thinking import ThinkingBudgetProcessor

think_start_id = self._get_think_token_id("think_start_id")
try:
think_start_id = getattr(self.tokenizer, 'think_start_id', None)
except (ValueError, TypeError):
think_start_id = None
leading_ids, trailing_ids = self._resolve_think_close_pattern()
processor = ThinkingBudgetProcessor(
think_end_token_ids=think_end_ids,
Expand Down Expand Up @@ -1770,7 +1773,11 @@ def _resolve_think_end_token_ids(self) -> list[int] | None:
</think> and </longcat_think> automatically.
"""
# Tier 1: mlx-lm tokenizer attribute (covers all known think variants)
think_end_id = self._get_think_token_id("think_end_id")
try:
think_end_id = getattr(self.tokenizer, 'think_end_id', None)
except (ValueError, TypeError):
# Multi-token think end (e.g. Gemma 4) - fall through to Tier 2
think_end_id = None
if think_end_id is not None:
return [think_end_id]

Expand Down Expand Up @@ -1888,7 +1895,12 @@ def _detect_needs_think_prefix(self, request: "Request") -> bool:
Returns False for disabled-thinking patterns like <think></think>
where </think> immediately follows <think> in the prompt tail.
"""
think_start_id = self._get_think_token_id("think_start_id")
try:
think_start_id = getattr(self.tokenizer, 'think_start_id', None)
except (ValueError, TypeError):
# Multi-token think start (e.g. Gemma 4 <|channel>thought) -
# single-token detection not applicable, handled by output parser
return False
if think_start_id is None:
try:
think_start_id = self.tokenizer.convert_tokens_to_ids("<think>")
Expand Down