Fix admin chat preserve_thinking history serialization#1329
Open
gindinconsulting wants to merge 1 commit into
Open
Fix admin chat preserve_thinking history serialization#1329gindinconsulting wants to merge 1 commit into
gindinconsulting wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
preserve_thinkingin the built-in admin chat UI.The raw
/v1/chat/completionsAPI preserves historical reasoning correctly when prior assistant messages includereasoning_content. However, the admin chat UI was storing streamed reasoning only in the UI-private_thinkingfield and then dropping it when serializing conversation history for the next request.This made
preserve_thinkingwork with raw API calls but fail inside the built-in chat.Changes
reasoning_contentwhen buildingmessagesForApi_thinkingso existing localStorage conversations continue to workreasoning_content, for API history replay_thinking, for existing UI renderingManual test
Tested locally with
Qwen3.6-35B-A3B-oQ8-mtp.Prompt 1:
Prompt 2:
Before this fix, the built-in chat could not retrieve the hidden second number because prior reasoning was not sent back. After this fix, the built-in chat returns the second number from preserved reasoning history.