Lift TurboQuant toggle restriction on ParoQuant models#1573
Open
felk-dev wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use ParoQuant model in openclaw and it works well without any collision.
However, since we cannot rule out potential hidden bugs, I replaced the hard restriction with a warning banner advising caution, while still allowing users to enable the option itself.
Key Changes:
Logic Update: Removed the modelSettings.is_paroquant condition from @click, :disabled, and :class attributes to allow the toggle to be operable even for ParoQuant models. (Mutual exclusivity is now maintained only with MTP, which remains incompatible).
UI Update: Designed a warning banner using x-show="modelSettings.is_paroquant" to display an amber warning icon and a cautionary notice when a ParoQuant model is detected.
Added Localization Strings
The multilingual translation strings for the warning banner have been added to the localization configuration files (such as ko.json and en.json) as follows:
"paroquant_turboquant_warning": "Warning: Using TurboQuant with ParoQuant models may cause accuracy degradation."