-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change V1Subject to RbacV1Subject in k8s.py #1384
base: main
Are you sure you want to change the base?
Conversation
This change fix: Error: module 'kubernetes.client' has no attribute 'V1Subject'
Thanks for submitting your first pull request! You are awesome! 🤗 |
Capping the client to 1.28 would make it work for current users, but would make it fail for users that have upgraded to >= 1.29 then... Another approach would be to try to check in the code for the current version and use one or the other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete it from a hacker
@lresende @kevin-bates I am running Kubernetes 1.31 with EG 3.2.2 since 3.2.3 has this issue, and everything works fine as far as I can see. That said, I think this PR is backward-compatible as looking at the commit that changes V1Subject to RbacV1Subject, only the model name is updated. I don't think this is a breaking change in the API, as I couldn't find any mentions of it in the v29 changelog. |
This change fix - Error: module 'kubernetes.client' has no attribute 'V1Subject'
This error occurs when an attempt is made to create a role binding.
The full error looks as follows: