Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translation Controls #529

Merged
merged 25 commits into from
Nov 6, 2024
Merged

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Oct 23, 2024

transform.mov

Shall partially supersede #151

@martinRenou martinRenou added the enhancement New Feature or improvement label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Preview PR at appsharing.space

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Integration tests repot: appsharing.space

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Integration tests report: appsharing.space

@arjxn-py arjxn-py marked this pull request as ready for review November 5, 2024 12:46
@arjxn-py arjxn-py requested review from martinRenou and trungleduc and removed request for martinRenou November 5, 2024 12:47
@arjxn-py arjxn-py changed the title [WIP]: Add Transform Controls Add Translation Controls Nov 5, 2024
@arjxn-py arjxn-py requested a review from martinRenou November 5, 2024 12:49
@martinRenou martinRenou mentioned this pull request Nov 5, 2024
2 tasks
@martinRenou
Copy link
Member

After some testing I think this is looking and working great.

Just one open question, do we want the transform control to be enabled for hidden objects? Happy to get your thoughts @arjxn-py @trungleduc @SylvainCorlay

Allowing this allows that workflow:

Screencast.From.2024-11-05.15-13-58.mp4

@arjxn-py
Copy link
Member Author

arjxn-py commented Nov 5, 2024

Just one open question, do we want the transform control to be enabled for hidden objects?

My first response to that would have been "No" but after looking at the workflow you've shared it looks like nice to have

@trungleduc
Copy link
Member

we might want to have an intermediate state for selected hidden object by playing with object's opacity.

@SylvainCorlay
Copy link
Member

Just one open question, do we want the transform control to be enabled for hidden objects?

My first response to that would have been "No" but after looking at the workflow you've shared it looks like nice to have

Same here. I saw it and though "cool!".

@martinRenou
Copy link
Member

we might want to have an intermediate state for selected hidden object by playing with object's opacity

I love it.

Though transparency can be tricky, but if it's just one object at a time that should be fine.

@arjxn-py
Copy link
Member Author

arjxn-py commented Nov 6, 2024

we might want to have an intermediate state for selected hidden object by playing with object's opacity.

Just this remaining, if i'm not forgetting anything (for translation)

@SylvainCorlay
Copy link
Member

Just this remaining, if i'm not forgetting anything (for translation)

This could be a separate PR.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo! Thanks a lot for this, happy to see this go in

@martinRenou martinRenou merged commit 709c792 into jupytercad:main Nov 6, 2024
10 checks passed
@arjxn-py arjxn-py deleted the transform-controls branch November 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants