Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes before first release #134

Merged
merged 15 commits into from
Aug 24, 2021

Conversation

cameron-toy
Copy link
Collaborator

@cameron-toy cameron-toy commented Aug 23, 2021

Addresses Issues #120, #117, #123

Major packaging and architecture changes, as well as QOL and interaction improvements.

  • Extension is separated into three packages: api, for core commenting components, notebook, for notebook commenting components, and text for text commenting components.
  • The functionality of the Monolithic CommentFactory has been separated among CommentWidgetFactory, CommentFactory, and CommentWidget. This should give a clearer mental model of the architecture and make extension easier for other developers.
  • Tighter coupling between comment files and source files. Deleting, saving, or renaming a file with comments now does the same to its associated comment file, even if it's not currently open.
  • Removed separate MockCommentWidget and added isMock options to regular CommentWidgets.
  • Updated @jupyterlab components
  • Added context menu delete/edit/rename options to comments.
  • Added context menu option for commenting on text files.
  • Various small fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant