Skip to content

Revert "Updates binderhub chart to 1.0.0-0.dev.git.3653.hb72cd888" #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

Revert "Updates binderhub chart to 1.0.0-0.dev.git.3653.hb72cd888" #3154

merged 1 commit into from
Jan 6, 2025
+1 −1

Conversation

@manics
Copy link
Member

@manics manics commented Jan 6, 2025

Reverts #3153

We'll need to update the tests in this repo to match jupyterhub/binderhub#1856

https://github.com/jupyterhub/mybinder.org-deploy/actions/runs/12630032767/job/35189045411

=================================== FAILURES ===================================
_______________________________ test_proxy_page ________________________________
[gw1] linux -- Python 3.10.15 /opt/hostedtoolcache/Python/3.10.15/x64/bin/python

helm_config = {'analyticsPublisher': {'cloudCosts': {'enabled': True, 'fileName': 'cloud-costs.jsonl', 'kind': 'csv', 'sourceBucket'...VENT_LOG_NAME': 'binderhub-staging-events-text'}, ...}, 'binderhub-container-registry-helper': {'enabled': False}, ...}
federation_url = 'https://staging.mybinder.org/'

    def test_proxy_page(helm_config, federation_url):
        r = requests.get(federation_url)
        r.raise_for_status()
>       assert "How it works" in r.text
E       assert 'How it works' in '<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta charset="utf-8">\n  <title>Binder</title>\n  \n  \n  <meta property="og:title" content="The Binder Project">\n  <meta property="og:image" content="/static/images/logo_social.png?v=c9036f8cabaf6fc5a0f53c3017070d9283c572e53825819811b2d7b95698d15a62484c0d5a89fa1a5443a1b678df181ed9309f28742d42dcc0d52d54dfa44400">\n  <meta property="og:description" content="Reproducible, sharable, open, interactive computing environments.">\n  <meta property="og:image:width" content="1334">\n  <meta property="og:image:height" content="700">\n  <meta property="og:image:alt" content="The Binder Project Logo" />\n  <meta name="twitter:card" content="summary_large_image">\n  \n  <link id="favicon" rel="shortcut icon" type="image/png" href="/static/favicon.ico?v=a3a57d0630d11611c499ba1adad64b1ecff1e9c3b4f2b2c1abffe4cd3ce642378418eddc6b6df9b7b799ba41364c60e7daac2bd65f45784c30ed58a6ed798c7e" />\n  <link href="/static/dist/styles.css?v=ad04313cbde9abfc12b320eabe87bcb800abfdbaf92aa28687e7e72e4a182335b7ff120dfee1d42fdb624ca773770e535c496b05228fb46481b2951e3dc3579f" rel="stylesheet"></link>\n\n  <script>\n    window.pageConfig = {"aboutMessage": "\\u003cp\\u003...30456a053e49131448a558628eaee5e6931e7d8df8af7a2c6f9"></script>\n\n\n\n<script>\n  // Only load Matomo if DNT is not set.\n// This respects user preferences, and gives us a full score on uBlock origin\nif (navigator.doNotTrack != "1" && // Most Firefox & Chrome\n  window.doNotTrack != "1" && // IE & Safari\n  navigator.msDoNotTrack != "1" // Old IE\n) {\nconsole.log("Loading Matomo tracking, since Do Not Track is off");\n  var _paq = _paq || [];\n  /* tracker methods like "setCustomDimension" should be called before "trackPageView" */\n  // this is matomo\'s own respect-DoNotTrack\n  // should be redundant, but good to be extra explicit\n  _paq.push(["setDoNotTrack", true]);\n  // disable tracking cookies\n  _paq.push(["disableCookies"]);\n  _paq.push([\'trackPageView\']);\n  (function() {\n    var u="//" + window.location.hostname + "/matomo/";\n    _paq.push([\'setTrackerUrl\', u+\'piwik.php\']);\n    _paq.push([\'setSiteId\', \'1\']);\n    var d=document, g=d.createElement(\'script\'), s=d.getElementsByTagName(\'script\')[0];\n    g.type=\'text/javascript\'; g.async=true; g.defer=true; g.src=u+\'piwik.js\'; s.parentNode.insertBefore(g,s);\n  })();\n}\n\n</script>\n\n\n\n</html>'
E        +  where '<!DOCTYPE html>\n<html lang="en">\n<head>\n  <meta charset="utf-8">\n  <title>Binder</title>\n  \n  \n  <meta property="og:title" content="The Binder Project">\n  <meta property="og:image" content="/static/images/logo_social.png?v=c9036f8cabaf6fc5a0f53c3017070d9283c572e53825819811b2d7b95698d15a62484c0d5a89fa1a5443a1b678df181ed9309f28742d42dcc0d52d54dfa44400">\n  <meta property="og:description" content="Reproducible, sharable, open, interactive computing environments.">\n  <meta property="og:image:width" content="1334">\n  <meta property="og:image:height" content="700">\n  <meta property="og:image:alt" content="The Binder Project Logo" />\n  <meta name="twitter:card" content="summary_large_image">\n  \n  <link id="favicon" rel="shortcut icon" type="image/png" href="/static/favicon.ico?v=a3a57d0630d11611c499ba1adad64b1ecff1e9c3b4f2b2c1abffe4cd3ce642378418eddc6b6df9b7b799ba41364c60e7daac2bd65f45784c30ed58a6ed798c7e" />\n  <link href="/static/dist/styles.css?v=ad04313cbde9abfc12b320eabe87bcb800abfdbaf92aa28687e7e72e4a182335b7ff120dfee1d42fdb624ca773770e535c496b05228fb46481b2951e3dc3579f" rel="stylesheet"></link>\n\n  <script>\n    window.pageConfig = {"aboutMessage": "\\u003cp\\u003...30456a053e49131448a558628eaee5e6931e7d8df8af7a2c6f9"></script>\n\n\n\n<script>\n  // Only load Matomo if DNT is not set.\n// This respects user preferences, and gives us a full score on uBlock origin\nif (navigator.doNotTrack != "1" && // Most Firefox & Chrome\n  window.doNotTrack != "1" && // IE & Safari\n  navigator.msDoNotTrack != "1" // Old IE\n) {\nconsole.log("Loading Matomo tracking, since Do Not Track is off");\n  var _paq = _paq || [];\n  /* tracker methods like "setCustomDimension" should be called before "trackPageView" */\n  // this is matomo\'s own respect-DoNotTrack\n  // should be redundant, but good to be extra explicit\n  _paq.push(["setDoNotTrack", true]);\n  // disable tracking cookies\n  _paq.push(["disableCookies"]);\n  _paq.push([\'trackPageView\']);\n  (function() {\n    var u="//" + window.location.hostname + "/matomo/";\n    _paq.push([\'setTrackerUrl\', u+\'piwik.php\']);\n    _paq.push([\'setSiteId\', \'1\']);\n    var d=document, g=d.createElement(\'script\'), s=d.getElementsByTagName(\'script\')[0];\n    g.type=\'text/javascript\'; g.async=true; g.defer=true; g.src=u+\'piwik.js\'; s.parentNode.insertBefore(g,s);\n  })();\n}\n\n</script>\n\n\n\n</html>' = <Response [200]>.text

tests/test_federation_redirect.py:16: AssertionError

@manics manics merged commit 1ea9337 into main Jan 6, 2025
10 checks passed
@manics manics deleted the revert-3153-update-chart-binderhub branch January 6, 2025 09:55
@manics manics mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manics