Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement message attachments #148

Merged
merged 19 commits into from
Feb 17, 2025
Merged

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jan 17, 2025

Description

Demo

record-2025-02-13_11.04.21.webm

There is now a lite deployment in the built doc including a simple extension with a chat panel. I updated it to allow attachments https://jupyter-chat--148.org.readthedocs.build/en/148/lite/lab/index.html

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/message_attachments

@brichet brichet changed the title [WIP] message attachments Message attachments Jan 22, 2025
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brichet Thank you for working on this while I was away! Left some feedback below.

@brichet
Copy link
Collaborator Author

brichet commented Feb 6, 2025

Thanks for the review @dlqqq, I addressed some of your comments. I'll take a look at an alternative to clickAttachments().

@brichet brichet force-pushed the message_attachments branch from 2658548 to f9f5a6b Compare February 12, 2025 15:35
@brichet brichet marked this pull request as ready for review February 13, 2025 12:43
@brichet
Copy link
Collaborator Author

brichet commented Feb 13, 2025

The recurrent failing test do not fails locally. And strangely, it constantly fails at opening the chat, which is done in other tests with the same chat file...

@brichet
Copy link
Collaborator Author

brichet commented Feb 14, 2025

The recurrent failing test do not fails locally. And strangely, it constantly fails at opening the chat, which is done in other tests with the same chat file...

The failing test is the first one of the notification tests. After reordering the tests, the 'new' first test is now failing.
I'll try to fix it, otherwise we would have to disable the whole test group.

@brichet brichet force-pushed the message_attachments branch from 6402bb1 to 217ed22 Compare February 14, 2025 16:07
@brichet
Copy link
Collaborator Author

brichet commented Feb 14, 2025

I finally skipped the notification test for now, I'll open a issue when this PR is merged to restore it in a follow up PR.

@dlqqq dlqqq changed the title Message attachments Implement message attachments Feb 17, 2025
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brichet, the new changes look great! Left some additional minor feedback.

Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this PR because my latest feedback is minor & non-blocking.

If you do merge, please open follow-up issues for my latest feedback, thank you!

@brichet brichet force-pushed the message_attachments branch from 217ed22 to cc6634f Compare February 17, 2025 21:26
@brichet brichet merged commit f5dc9bc into jupyterlab:main Feb 17, 2025
12 checks passed
@brichet brichet deleted the message_attachments branch February 17, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design a way to attach JSON objects to messages
3 participants