-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to a newer @langchain/community
to fix ChromeAI integration
#43
Conversation
@langchain/community
@@ -0,0 +1,13 @@ | |||
diff --git a/node_modules/@langchain/community/dist/experimental/llms/chrome_ai.js b/node_modules/@langchain/community/dist/experimental/llms/chrome_ai.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file (and the patch-package
/ postinstall-postinstall
dependencies) can be removed later after updating to a newer version of @langchain/community
what would include langchain-ai/langchainjs#7700.
Right, but I also tried locally with the wheel built by check-release in #27 (before supporting streaming), and it was the same issue. |
@langchain/community
@langchain/community
to fix ChromeAI integration
langchain-ai/langchainjs#7700 has been merged and released, so we can remove the patch here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @jtpio .
BTW, I didn't know the patch workaround, nice to temporary fix an upstream issue 👍
Thanks for the review!
Yeah it is indeed convenient and somewhat "clean" :) |
ChromeAI was recently giving some really weird results, pretty much gibberish.
This was odd because using the API in the dev tools directly seems to be working fine:
Digging a bit more into it, it looks like an issue in the
@langchain/community
package.I opened a PR upstream, which seems to be fixing the issue with the latest Chrome 133 release (as of today): langchain-ai/langchainjs#7700
Before
After
With streaming:
jupyterlite-ai-chromeai-streaming.mp4