Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation around fullscreen usage of jupyterlite-sphinx apps #253

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Update documentation around fullscreen usage of jupyterlite-sphinx apps #253

merged 6 commits into from
Feb 12, 2025

Conversation

agriyakhetarpal
Copy link
Member

Description

This PR makes some documentation updates. In specific:

  • some grammatical errors have been fixed
  • updated headings
  • added missing links to REPL and Voici apps running in fullscreen
  • added tips on how to open a notebook by specifying its path for the JupyterLite/Notebook/Voici apps' URLs
  • added a small note on customising the REPL with a link to the REPL's complete documentation in JupyterLite upstream

@agriyakhetarpal agriyakhetarpal added the documentation Improvements or additions to documentation label Jan 13, 2025
@agriyakhetarpal agriyakhetarpal added this to the 0.19.0 milestone Jan 13, 2025
@agriyakhetarpal agriyakhetarpal mentioned this pull request Jan 14, 2025
Closed
3 tasks
agriyakhetarpal
agriyakhetarpal commented Feb 12, 2025
View reviewed changes
docs/full.md Outdated Show resolved Hide resolved
steppi
steppi reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agriyakhetarpal. A few minor comments.

docs/full.md Outdated Show resolved Hide resolved
docs/full.md Outdated Show resolved Hide resolved
@agriyakhetarpal
Copy link
Member Author

Thanks for the review, @steppi!

agriyakhetarpal
agriyakhetarpal commented Feb 12, 2025
View reviewed changes
docs/full.md Outdated Show resolved Hide resolved
steppi
steppi approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agriyakhetarpal, this looks good to me now.

@steppi steppi merged commit 9cf9a24 into jupyterlite:main Feb 12, 2025
5 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/fullscreen-documentation branch February 12, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steppi steppi steppi approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@agriyakhetarpal @steppi