build(deps): bump node from 24-bookworm-slim to 26-bookworm-slim - #1
dependabot[bot] wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe Dockerfile now uses Node.js 26 with Debian bookworm slim for both build and runtime stages. ChangesContainer runtime
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Dockerfile (1)
1-1: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winAdd Node.js 26 container coverage to CI.
The Docker stages now build and run under Node.js 26, while the supplied CI and security workflows still execute on Node.js 24. Add a Docker build/smoke test or update the relevant workflow jobs so Node.js 26-specific regressions are exercised before release.
Also applies to: 10-10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` at line 1, Update the relevant CI and security workflow jobs to exercise Node.js 26, matching the Dockerfile’s node:26-bookworm-slim build and runtime stages. Add a Docker build/smoke test or otherwise ensure the workflows validate Node.js 26-specific behavior before release, including the corresponding configuration at the referenced secondary location.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 1: Update both Dockerfile stages around the existing corepack enable
steps to install Corepack or pnpm before invoking corepack enable, ensuring the
Node.js 26 image can execute the package-manager setup successfully.
---
Nitpick comments:
In `@Dockerfile`:
- Line 1: Update the relevant CI and security workflow jobs to exercise Node.js
26, matching the Dockerfile’s node:26-bookworm-slim build and runtime stages.
Add a Docker build/smoke test or otherwise ensure the workflows validate Node.js
26-specific behavior before release, including the corresponding configuration
at the referenced secondary location.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| @@ -1,4 +1,4 @@ | |||
| FROM node:24-bookworm-slim AS build | |||
| FROM node:26-bookworm-slim AS build | |||
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/sh
set -eu
docker run --rm node:26-bookworm-slim sh -lc 'command -v corepack'Repository: jusso-dev/Muster
Length of output: 198
🏁 Script executed:
#!/bin/sh
set -eu
printf '\n== Dockerfile ==\n'
cat -n Dockerfile
printf '\n== CI / workflow files mentioning node ==\n'
git ls-files '.github/**' | while IFS= read -r f; do
grep -nE 'node:|actions/setup-node|corepack|pnpm' "$f" || true
doneRepository: jusso-dev/Muster
Length of output: 2162
🌐 Web query:
Node.js 26 corepack bundled removed node 25 documentation corepack executable not included
💡 Result:
Corepack is no longer bundled with Node.js starting from version 25.0.0 [1][2]. The Node.js Technical Steering Committee decided to stop distributing the Corepack executable in Node.js 25+ releases, ending a period where it was distributed with Node.js versions 14.19.0 and 16.9.0 through 24.x [1][3]. If you were previously relying on the bundled corepack executable, you can continue using Corepack by installing it as a userland package via npm [1][4]. You can install it globally by running: npm install -g corepack@latest This command provides the same corepack functionality that was previously included in the Node.js distribution [5][4]. Node.js documentation has been updated to reflect this change and to direct users to the Corepack repository for installation instructions [1][6].
Citations:
- 1: https://nodejs.org/dist/latest/docs/api/corepack.html
- 2: https://github.com/nodejs/nodejs.org/blob/main/apps/site/pages/en/blog/release/v25.0.0.md
- 3: doc: note corepack package removal in distribution doc nodejs/node#61207
- 4: deps: remove corepack nodejs/node#51981
- 5: https://github.com/nodejs/corepack?tab=readme-ov-file
- 6: nodejs/node@570d8d3f10
Install Corepack before corepack enable. Node.js 26 no longer ships the bundled corepack binary, so the corepack enable steps in both stages will fail unless Corepack or pnpm is installed first.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` at line 1, Update both Dockerfile stages around the existing
corepack enable steps to install Corepack or pnpm before invoking corepack
enable, ensuring the Node.js 26 image can execute the package-manager setup
successfully.
Bumps node from 24-bookworm-slim to 26-bookworm-slim. --- updated-dependencies: - dependency-name: node dependency-version: 26-bookworm-slim dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
ceb435e to
b5344f6
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
* chore(runtime): cut over to Node 26 across runtime and types Coordinated Node 24 → 26 upgrade for engines, @types/node, CI, Compose mocks, Docker build image, and distroless runtime. Records support policy and closes the #34 rollup that Dependabot PRs #1 and #8 could not land alone. * fix(ci): Node 26 corepack install and drizzle migration snapshots Official node:26-bookworm-slim no longer ships corepack on PATH. Replace hand-written migrations 0022/0023 with drizzle-kit output so the committed-migrations CI check stays clean. * chore(test): remove retired web UI Playwright E2E suite Drop browser E2E specs, Playwright configs/deps, and CI steps. Muster is the Hermes MCP control plane; unit/package tests and homelab shell checks remain. * docs: drop Playwright from Node 26 release checklist * ci: cut PR wall-clock — parallel jobs, one image build, Docker cache - Cancel in-progress PR runs - Drop MinIO from quality (unit tests mock object storage) - Turbo local cache on GHA - Parallel quality + container (container no longer waits on quality for PRs) - Remove duplicate full image build from security workflow on PR/push (weekly schedule retains deep Trivy pass) - Dockerfile: manifest-first layers + pnpm/turbo BuildKit caches - Tighter .dockerignore for smaller build context * fix(docker): drop unsupported COPY --parents for BuildKit 1.7 GHA buildx rejects --parents on dockerfile:1.7. Use explicit per-package manifest COPY lines so the lockfile-first layer cache still works.
Bumps node from 24-bookworm-slim to 26-bookworm-slim.