Adding the mandatory jsonrpc version identification #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added JSON-RPC version declaration in onFailure and onSuccess handlers.
* Removed handleInvalidRequest() * Added handleError with JSON error object * Now returning JSON-RPC as it is in the specs (http://groups.google.com/group/json-rpc/web/json-rpc-2-0?pli=1) * Prevented server crashes because of invalid JSON * Changed callback syntax used by the server functions (look at README) * Allowing extra error callback or error parameter in success callback at the client
|
seriously guys, this should be pulled in |
Upgrade to GitHub-native Dependabot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'jsonrpc': '2.0' to the string sent over the network as required by the spec.