Conversation
… fixes
Wave 1 (P0-P2):
- skills-core.js: path traversal via resolveSkillPath — validateSkillName()
rejects ../, slashes, non-alphanumeric before path.join
- comms.py: stale model ID → claude-sonnet-4-6-20250514, retry with
backoff for ConnectError/TimeoutException, exception class in logs
- agent-outcome-logger.py: 10MB rotation guard, crash-proof outer wrapper
- test_scanner.py: temp file leak → TemporaryDirectory, +nested dir test
Wave 2 (P1-P2, 5-agent team):
- scanner.py: ReDoS in MUST/NEVER lookahead → capped .{0,120}, skip
.git/node_modules/__pycache__ in scan_directory
- setup.sh: auto-register PostToolUse hook via jq (idempotent), validate
GSD dir exists before symlinking
- install.sh: unsafe cd → subshells, platform detection for prebuilt
binaries, --build flag, better error context from cargo
- superpowers.js: sanitize OPENCODE_CONFIG_DIR against prompt injection,
CRLF support in frontmatter regex, race condition guard on readFileSync
- analyze-token-usage.py: bare except → typed catch, MODEL_PRICING table
(opus/sonnet/haiku), cache read 90% discount, type-safe dicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits: the POP dispatcher/comms library, and a 9-file adversarial security + reliability audit.
POP Dispatcher (
283d535)lib/comms.py:generate(),vm_generate(),health(),discover()Adversarial Hardening (
3e94a0c)lib/skills-core.jsvalidateSkillName()rejects../,/,\lib/comms.pyclaude-sonnet-4-6-20250514, retry + backoffscanner.py.{0,120}capsetup.shmcp-servers/install.sh.opencode/plugins/superpowers.jshooks/agent-outcome-logger.pytest_scanner.pytests/claude-code/analyze-token-usage.pyTest plan
python test_scanner.py— 10/10 passnode -e "import('./lib/skills-core.js')..."— validateSkillName blocks traversal, allows valid namesast.parse)cargo teston MCP servers (no changes to Rust code)