feat: address all 7 open issues — full sweep#15
Merged
Conversation
47 files changed, +739/-14 lines
- test_subagent_orchestration_hint_on_three_branches (3 branches → hint fires) - test_subagent_orchestration_suppressed_during_merge (merge → no hint) - test_push_files_commit_creation_fails_reports_tree_plus_blobs (step 5) 22/22 seqthink tests, 21/21 push_files tests passing
- push_files: replace Vec<String> blob tracker with usize counter (reviewer issue 2) - push_files: add orphan count to step 3 partial failure message (consistency) - seqthink: deduplicate merge_available vs subagent_orchestration hints merge_available fires at exactly 2 branches, orchestration owns 3+ (reviewer issue 1/4)
Edit→replace (not edit_file), WebSearch→google_web_search, WebFetch→web_fetch, Grep→search_file_content, TodoWrite→write_todos
- Rename test_push_files_atomic_* → test_push_files_* (no longer claims atomicity) - Fix seqthink profile claims: both Gemini/Claude use depth 2, not 2 vs 3 - GSD strategy: add snapshot date, fix semver notation (- not +) - Simulation doc: clarify var/archetypes/ is convention, not existing dir
aee45d9 to
a8ae59f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all 7 open issues in a single sweep: 50 files changed, +1066/-14 lines.
Issues Addressed
Rust Changes (tested)
subagent_spawn_available+subagent_orchestrationhints, 20/20 tests passNew Documents
docs/gemini-compatibility.md— Full tool name mapping + compat guidedocs/gsd-upstream-strategy.md— Selective merge plan for v1.27-v1.30docs/simulation-extensibility.md— JSON interface for simulation clientsTest plan
cargo test tools::files— 20 passedcargo test— 20 passed