Skip to content

Commit

Permalink
Try a white sidebar (WordPress#10062)
Browse files Browse the repository at this point in the history
* Try a white sidebar

This PR extracts an idea from WordPress#9784, a white sidebar.

This looks a little jarring at first, but can grow on you. Because it's sort of a jarring change, I think it needs to be tested in a PR, rather than be discussed. That way people can actually _feel_ it, rather than look at screenshots.

What do you think?

* Try sticky and light gray tabs

* Address feedback.
  • Loading branch information
jasmussen authored Sep 30, 2018
1 parent 58fd2d1 commit a5cad2b
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions edit-post/assets/stylesheets/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ $z-layers: (
".editor-block-list__layout .reusable-block-indicator": 1,
".editor-block-list__breadcrumb": 2,
".components-form-toggle__input": 1,
".components-panel__header.edit-post-sidebar__panel-tabs": 1,
".editor-inserter__tabs": 1,
".editor-inserter__tab.is-active": 1,
".components-panel__header": 1,
Expand Down
6 changes: 5 additions & 1 deletion edit-post/components/sidebar/settings-header/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@
padding-left: 0;
padding-right: $grid-size-small;
border-top: 0;
background: $light-gray-200;
position: sticky;
z-index: z-index(".components-panel__header.edit-post-sidebar__panel-tabs");
top: 0;
}

.edit-post-sidebar__panel-tab {
background: transparent;
border: none;
border-radius: 0;
cursor: pointer;
height: 50px;
height: $grid-size * 6;
padding: 3px 15px; // Use padding to offset the is-active border, this benefits Windows High Contrast mode
margin-left: 0;
font-weight: 400;
Expand Down
2 changes: 1 addition & 1 deletion edit-post/components/sidebar/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
bottom: 0;
width: $sidebar-width;
border-left: $border-width solid $light-gray-500;
background: $light-gray-300;
background: $white;
color: $dark-gray-500;
height: 100vh;
overflow: hidden;
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/panel/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
display: flex;
justify-content: space-between;
align-items: center;
background: $light-gray-300;
padding: 0 $panel-padding;
height: 50px;
border-top: $border-width solid $light-gray-500;
Expand Down

0 comments on commit a5cad2b

Please sign in to comment.