Add a few missing types to predicates (WIP) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justuswilhelm
force-pushed
the
add-typings
branch
from
82f6ebe to
e572376
Compare
Tested by running mypy on rules/predicates.py with the following
settings in pyproject.toml:
[tool.mypy]
[[tool.mypy.overrides]]
module = [
"rules.predicates"
]
disallow_untyped_defs = true
justuswilhelm
force-pushed
the
add-typings
branch
from
e572376 to
0b5dabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running mypy on rules/predicates.py with the following settings in pyproject.toml:
[tool.mypy]
[[tool.mypy.overrides]]
module = [
"rules.predicates"
]
disallow_untyped_defs = true