Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Enforce US spelling #5659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[lint] Enforce US spelling #5659

wants to merge 1 commit into from

Conversation

s3rj1k
Copy link

@s3rj1k s3rj1k commented Mar 12, 2025

Description

Enables misspell linter and forces US spelling for whole codebase.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@s3rj1k s3rj1k requested review from a team as code owners March 12, 2025 15:50
@s3rj1k s3rj1k requested review from kke and jnummelin March 12, 2025 15:50
ncopa
ncopa previously approved these changes Mar 19, 2025
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those L vs. double L mismatches, oh my - Can't the US and UK agree on that? 🤣

There are still some double Ls around, it seems:

pkg/component/controller/apiendpointreconciler.go:1: : # github.com/k0sproject/k0s/pkg/component/controller [github.com/k0sproject/k0s/pkg/component/controller.test]
pkg/component/controller/k0scloudprovider_test.go:78:80: suite.cancelled undefined (type *K0sCloudProviderSuite has no field or method cancelled)
pkg/component/controller/k0scloudprovider_test.go:100:19: suite.cancelled undefined (type *K0sCloudProviderSuite has no field or method cancelled) (typecheck)
/*
pkg/component/controller/clusterconfig_test.go:28:2: could not import github.com/k0sproject/k0s/pkg/component/controller (-: # github.com/k0sproject/k0s/pkg/component/controller [github.com/k0sproject/k0s/pkg/component/controller.test]
pkg/component/controller/k0scloudprovider_test.go:78:80: suite.cancelled undefined (type *K0sCloudProviderSuite has no field or method cancelled)
pkg/component/controller/k0scloudprovider_test.go:100:19: suite.cancelled undefined (type *K0sCloudProviderSuite has no field or method cancelled)) (typecheck)
        "github.com/k0sproject/k0s/pkg/component/controller"
        ^

@s3rj1k s3rj1k force-pushed the misspell branch 2 times, most recently from 4c2350b to b831cf3 Compare March 19, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants