Skip to content

Feature/reduce gem size - #486

Open
frezbo wants to merge 1 commit into
k1LoW:mainfrom
frezbo:feature/reduce-gem-size
Open

Feature/reduce gem size#486
frezbo wants to merge 1 commit into
k1LoW:mainfrom
frezbo:feature/reduce-gem-size

Conversation

@frezbo

@frezbo frezbo commented Sep 13, 2019

Copy link
Copy Markdown

This tries to reduce the gem dependencies to only what is being used.

Signed-off-by: Noel Georgi <git@frezbo.com>
@k1LoW

k1LoW commented Sep 15, 2019

Copy link
Copy Markdown
Owner

Hi @frezbo Thank you for you commit!!

I have one question. Why do you want to reduse the gem dependencies ?

I think it's more important to be easier when someone adds a new resource than the size of the gem.

@frezbo

frezbo commented Sep 17, 2019

Copy link
Copy Markdown
Author

@k1LoW Yes I agree to the ease of adding a new gem, but the existing code also means that any gem project depending on awspec also gets all the unwanted aws dependencies. I will leave it up to the authors on the final decision. I'm still ok keeping all considering supporting new resources.

@frezbo frezbo closed this Sep 17, 2019
@frezbo frezbo reopened this Sep 17, 2019
@k1LoW

k1LoW commented Sep 18, 2019

Copy link
Copy Markdown
Owner

@frezbo Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants