Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #790

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Remove deprecated code #790

merged 2 commits into from
Feb 9, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Feb 9, 2024

SSIA.

@k1LoW k1LoW self-assigned this Feb 9, 2024

This comment has been minimized.

@k1LoW k1LoW force-pushed the remove-deprecated branch from e1a4071 to 999f2ab Compare February 9, 2024 15:34
Copy link
Contributor

github-actions bot commented Feb 9, 2024

BenchmarkManyRunbooks-4

main (-) #790 (35d5b78) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,690,014,685 ns/op 3,361,205,964 ns/op -328,808,721 ns/op
Bytes allocated per iteration 1,545,014,720 B/op 1,543,477,960 B/op -1,536,760 B/op
Allocs per iteration 17,130,538 allocs/op 17,124,300 allocs/op -6,238 allocs/op
Metadata
main (-) #790 (35d5b78)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #790 (35d5b78) +/-
Number of iterations 20 21 1
Nanoseconds per iteration 56,099,701 ns/op 55,243,415 ns/op -856,286 ns/op
Bytes allocated per iteration 57,393,597 B/op 57,385,464 B/op -8,133 B/op
Allocs per iteration 163,098 allocs/op 163,050 allocs/op -48 allocs/op
Metadata
main (-) #790 (35d5b78)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Code Metrics Report

main (8735ea0) #790 (35d5b78) +/-
Coverage 70.2% 70.4% +0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 3m22s 2m40s -42s
Details
  |                     | main (8735ea0) | #790 (35d5b78) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          70.2% |          70.4% | +0.1% |
  |   Files             |             50 |             49 |    -1 |
  |   Lines             |           9369 |           9353 |   -16 |
  |   Covered           |           6581 |           6581 |     0 |
+ | Code to Test Ratio  |          1:0.7 |          1:0.7 |  +0.0 |
  |   Code              |          12897 |          12874 |   -23 |
- |   Test              |           9544 |           9542 |    -2 |
+ | Test Execution Time |          3m22s |          2m40s |  -42s |

Code coverage of files in pull request scope (62.2% → 63.3%)

Files Coverage +/-
builtin/json.go 0.0% 0.0%
option.go 63.3% +0.7%

Reported by octocov

@k1LoW k1LoW merged commit b1ad913 into main Feb 9, 2024
@k1LoW k1LoW deleted the remove-deprecated branch February 9, 2024 15:40
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant