Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge run() function context and runner (chrome) context #791

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Feb 12, 2024

SSIA. And delay the timing of Chrome startup.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #791 (fc4274f) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,311,295,430 ns/op 3,308,819,037 ns/op -2,476,393 ns/op
Bytes allocated per iteration 1,543,578,952 B/op 1,544,422,192 B/op 843,240 B/op
Allocs per iteration 17,124,746 allocs/op 17,124,935 allocs/op 189 allocs/op
Metadata
main (-) #791 (fc4274f)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #791 (fc4274f) +/-
Number of iterations 20 20 0
Nanoseconds per iteration 54,647,549 ns/op 54,050,667 ns/op -596,882 ns/op
Bytes allocated per iteration 57,390,382 B/op 57,376,101 B/op -14,281 B/op
Allocs per iteration 163,048 allocs/op 163,051 allocs/op 3 allocs/op
Metadata
main (-) #791 (fc4274f)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (b1ad913) #791 (fc4274f) +/-
Coverage 70.4% 70.3% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.0
Test Execution Time 2m43s 2m55s +12s
Details
  |                     | main (b1ad913) | #791 (fc4274f) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          70.4% |          70.3% | -0.1% |
  |   Files             |             49 |             49 |     0 |
  |   Lines             |           9353 |           9355 |    +2 |
- |   Covered           |           6581 |           6576 |    -5 |
- | Code to Test Ratio  |          1:0.7 |          1:0.7 |  -0.0 |
  |   Code              |          12874 |          12876 |    +2 |
  |   Test              |           9542 |           9542 |     0 |
- | Test Execution Time |          2m43s |          2m55s |  +12s |

Code coverage of files in pull request scope (71.8% → 70.0%)

Files Coverage +/-
cdp.go 70.0% -1.8%

Reported by octocov

@k1LoW k1LoW merged commit 28fc4d5 into main Feb 12, 2024
@k1LoW k1LoW deleted the fix-cdp branch February 12, 2024 15:13
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant