Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streaming_decode.py, relax the audio range from [-1,+1] to [-10,+10] #1448

Merged
merged 1 commit into from
Jan 5, 2024
Merged

streaming_decode.py, relax the audio range from [-1,+1] to [-10,+10] #1448

merged 1 commit into from
Jan 5, 2024

Conversation

KarelVesely84
Copy link
Contributor

  • some AudioTransform classes produce audio signals out of range [-1,+1]
    • Resample produced 1.0079
    • The range [-10,+10] was chosen to still be able to reliably distinguish from the [-32k,+32k] signal...
  • this is related to : Audio range out of (-1,+1) lhotse-speech/lhotse#1254

@csukuangfj
Copy link
Collaborator

Thanks! Looks good to me.

@KarelVesely84 KarelVesely84 force-pushed the streaming_decode_relax_audio_range branch from 849a93a to 6c389ab Compare January 4, 2024 15:51
@KarelVesely84
Copy link
Contributor Author

KarelVesely84 commented Jan 4, 2024 •
edited
Loading

fixed with black to pass the style_check

@KarelVesely84
streaming_decode.py, relax the audio range from [-1,+1] to [-10,+10]
bd5b9b0 
- some AudioTransform classes produce audio signals out of range [-1,+1]
   - Resample produced 1.0079
   - The range [-10,+10] was chosen to still be able to reliably
     distinguish from the [-32k,+32k] signal...
- this is related to : lhotse-speech/lhotse#1254
@KarelVesely84 KarelVesely84 force-pushed the streaming_decode_relax_audio_range branch from 6c389ab to bd5b9b0 Compare January 4, 2024 15:56
@csukuangfj csukuangfj merged commit 716b82c into k2-fsa:master Jan 5, 2024
54 checks passed
@ezerhouni
Copy link
Collaborator

@csukuangfj Should we propagate this fix to Sherpa ?

@csukuangfj
Copy link
Collaborator

@csukuangfj Should we propagate this fix to Sherpa ?

Could you remind me whether we have such a check in sherpa?

@ezerhouni
Copy link
Collaborator

@csukuangfj My bad, normalize_samples in sherpa is used for kaldi style features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarelVesely84 @csukuangfj @ezerhouni