Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve infinity-check #1862

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Improve infinity-check #1862

merged 1 commit into from
Jan 9, 2025

Conversation

zhu-han
Copy link
Contributor

@zhu-han zhu-han commented Jan 9, 2025

  1. Attach the inf-check hooks if the grad scale is getting too small.
  2. Add try-catch to avoid OOM in the inf-check hooks.
  3. Set warmup_start=0.1 to reduce chances of divergence.

@zhu-han
Improve infinity-check
a580f7f 
1. Attach the inf-check hooks if the grad scale is getting too small.
2. Add try-catch to avoid OOM in the inf-check hooks.
3. Set warmup_start=0.1 to reduce chances of divergence
csukuangfj
csukuangfj approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csukuangfj csukuangfj merged commit ab91112 into k2-fsa:master Jan 9, 2025
181 of 213 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfyeung yfyeung yfyeung approved these changes

@csukuangfj csukuangfj csukuangfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhu-han @csukuangfj @yfyeung