Add readiness endpoint #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following variables IMAGE_NAME, IMAGE_TAG_BASE, VERSION, IMG and CONTAINER_TOOL
Endpoint /ready is on port 8081 It will return a 200 status code when configuration has been applied and all processes in the process manager are running and have collected a metric
|
Thanks for your PR, |
aneeshkp
reviewed
Feb 14, 2025
| .PHONY: test | ||
| default: | ||
| ./hack/build.sh | ||
| image: | ||
| ./hack/build-image.sh | ||
| push: | ||
| docker push ghcr.io/k8snetworkplumbingwg/linuxptp-daemon-image:latest |
aneeshkp
reviewed
Feb 14, 2025
| @@ -1009,6 +1029,7 @@ func (p *ptpProcess) processPTPMetrics(output string) { | |||
| p.ProcessSynceEvents(logEntry) | |||
| } else { | |||
| configName, source, ptpOffset, clockState, iface := extractMetrics(p.messageTag, p.name, p.ifaces, output) | |||
| p.hasCollectedMetrics = true | |||
There was a problem hiding this comment.
you would know if there are metrics only if you have ptpOffset, I think That coould be good start. But if events are enable dthen extract metrics is moved to cloud-event-proxy and it will not enter into this condition .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.