Add vLLM v0.25.0 W2 upgrade candidate - #10
Open
OmarB97 wants to merge 4 commits into
Open
Conversation
Author
|
Post-merge v0.25 candidate canary is complete. Exact candidate
Results
Receipt hashes
This clears the draft canary condition. The v0.24 PR chain (#5-#9) remains frozen and unchanged. |
OmarB97
marked this pull request as ready for review
July 12, 2026 14:57
9prodhi
added a commit
to 9prodhi/vLLM-Moet
that referenced
this pull request
Jul 13, 2026
…sized-resume truncate, chmod fsync, no monitor/fd leak Re-review wave 2 (5 items on tools/plane_file.py, tools/build_plane_file.py, tools/test_plane_file.py): - [kacper-daftcode#7] CLI verify/build catch ALL exceptions at the boundary (KeyError/ TypeError from malformed-but-checksum-valid metadata, OSError) and exit non-zero with a one-line clean error; tracebacks behind a new --debug flag. - [kacper-daftcode#8] RSS budget is a HARD gate: _enforce_budget() aborts the build BEFORE finalization when the sampled monitor observes the budget exceeded; the .tmp is kept for resume and no finalized artifact is produced. - [kacper-daftcode#10] finalize() fsyncs the file inode after os.chmod(0o444) so the mode change is durable, not just the rename. - [new Important] resume normalizes an OVERSIZED .tmp: ftruncate back to the exact layout length (was: grow-only), never finalize a file verify rejects. - [new Minor] mon.start() + PlaneFileWriter construction moved inside the try/finally, monitor thread named + stop() guarded, and the writer ctor closes its fd if post-open validation raises: a resume-validation failure leaks neither the monitor thread nor an fd. TDD (failing test first) for kacper-daftcode#7, kacper-daftcode#8, and the oversized-resume item; regression tests for the leak item. Full suite: 73 passed, 0 failed (golden on CUDA). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a side-by-side W2 overlay and serving recipe for official vLLM v0.25.0 while preserving v0.24 as the proven default and rollback. This is a clean branch from upstream main; it does not pull in the fork-only merges or rewrite the frozen v0.24 PR chain.
Relationship to existing upstream PRs
PRs #5 through #9 remain the reviewable v0.24 implementation, safety, evaluation, receipts, and documentation chain. This PR is an independent additive v0.25 candidate. It does not supersede or retarget #5, because doing so would invalidate the frozen v0.24 evidence ancestry.
What changed
Verification
Risk and rollout
Draft until a disposable DS4 checkpoint canary proves the 128K retrieval, quality, memory/cgroup, and performance gates. Existing v0.24 images, packs, receipts, and router state remain the rollback.
Review note
The large file is the generated distribution patch. docs/v025-port.md contains the compatibility narrative, exact upstream-absorbed path inventory, teardown RCA, and bounded SM120 receipt; patch/FILES-v025.txt makes source-path additions and removals explicit.