Publish sanitized DS4 W2 release receipts - #8
Open
OmarB97 wants to merge 4 commits into
Open
Conversation
Document DS4 W2 release evidence boundaries
9prodhi
added a commit
to 9prodhi/vLLM-Moet
that referenced
this pull request
Jul 13, 2026
…sized-resume truncate, chmod fsync, no monitor/fd leak Re-review wave 2 (5 items on tools/plane_file.py, tools/build_plane_file.py, tools/test_plane_file.py): - [kacper-daftcode#7] CLI verify/build catch ALL exceptions at the boundary (KeyError/ TypeError from malformed-but-checksum-valid metadata, OSError) and exit non-zero with a one-line clean error; tracebacks behind a new --debug flag. - [kacper-daftcode#8] RSS budget is a HARD gate: _enforce_budget() aborts the build BEFORE finalization when the sampled monitor observes the budget exceeded; the .tmp is kept for resume and no finalized artifact is produced. - [kacper-daftcode#10] finalize() fsyncs the file inode after os.chmod(0o444) so the mode change is durable, not just the rename. - [new Important] resume normalizes an OVERSIZED .tmp: ftruncate back to the exact layout length (was: grow-only), never finalize a file verify rejects. - [new Minor] mon.start() + PlaneFileWriter construction moved inside the try/finally, monitor thread named + stop() guarded, and the writer ctor closes its fd if post-open validation raises: a resume-validation failure leaks neither the monitor thread nor an fd. TDD (failing test first) for kacper-daftcode#7, kacper-daftcode#8, and the oversized-resume item; regression tests for the leak item. Full suite: 73 passed, 0 failed (golden on CUDA). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release claims need reviewable raw receipts without publishing host topology, runtime identifiers, private paths, or protected pack/checkpoint fingerprints.
What changed
41d7b2fqualification from the final241ba984focused sentinel.How to review
Treat these 45 files as generated evidence. Check aggregate/manifests against their raw JSONL rows, inspect the P0 trace boundaries, and confirm that the frozen-RC sentinel does not relabel the earlier three-seed/three-depth series.
Evidence
All JSON and JSONL parse, all TSV rows retain a consistent column count, and the privacy scan finds no host alias, private address/path, opaque runtime ID, or credential pattern. The final checksum/index is intentionally added by the following narrative PR after these payloads land.
Verification
jq emptyon every JSON filejq -c .on every JSONL rowgit diff --checkRisks / gaps
This is deliberately a generated-data-only PR, so its line count is not hand-authored implementation complexity. The human narrative, cross-links, exact-image index, and 47-file checksum manifest are isolated in the final PR.
Collaborators