Optimize readBytes method to use ByteBuffer bulk operations#110
Open
SamareshSingh wants to merge 1 commit intokafka-dev:masterfrom
Open
Optimize readBytes method to use ByteBuffer bulk operations#110SamareshSingh wants to merge 1 commit intokafka-dev:masterfrom
SamareshSingh wants to merge 1 commit intokafka-dev:masterfrom
Conversation
Replace inefficient byte-by-byte loop with ByteBuffer's bulk get() method for better performance. The implementation now: - Uses buffer.get(bytes) to read all bytes at once (much faster) - Properly saves and restores the buffer position to maintain state - Removes the TODO comment as the optimization is now implemented Performance benefits: - Eliminates loop overhead (no iteration variable updates) - Uses native bulk copy operations (typically System.arraycopy under the hood) - Reduces method calls from O(n) to O(1) The try-finally block ensures the buffer's position is always restored even if an exception occurs during the read operation. Resolves TODO at line 101 in Utils.scala
|
@noj @jdamick @cburroughs Please take a look on this PR and let me know if you have any comment. |
|
can someone take a look into this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace inefficient byte-by-byte loop with ByteBuffer's bulk get() method for better performance.
Changes
buffer.get(bytes)to read all bytes at once (much faster)Performance Benefits
Implementation Details
The try-finally block ensures the buffer's position is always restored even if an exception occurs during the read operation.
Resolves