test: verify openshell.ai/owner label propagation via ComputeDriver#14
Merged
Conversation
Adds unit tests confirming the ComputeDriver's mergeMaps approach correctly propagates the gateway-stamped openshell.ai/owner label: - Sandbox CR receives owner label from template labels - Pod template spec receives owner label alongside driver labels - Driver's hardcoded labels do not overwrite the owner label - Owner and tenant labels coexist when Tenant config is set Part of per-user sandbox ownership (kagenti/kagenti#1976, Task B). Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openshell.ai/ownerlabel propagates from gateway template labels through to both the Sandbox CR and pod template specmergeMapsapproach does not overwrite the owner label (since the driver's hardcoded label set does not include it)Tenantconfig is setContext
Part of per-user sandbox ownership (kagenti/kagenti#1976, Task B).
The gateway (v0.0.56-rc.2) stamps
openshell.ai/owner = <identity.subject>onto sandbox create requests. This PR confirms the compute driver faithfully propagates that label without interference.Test plan
go test ./internal/driver/ -run "TestOwnerLabel" -v— all 4 tests passAssisted-By: Claude Code