Skip to content

fix(issuer): align implicit flow with RFC 6749#22

Merged
swalker326 merged 4 commits intomasterfrom
fix/implicit-flow-rfc-6749-compliance
Mar 21, 2026
Merged

fix(issuer): align implicit flow with RFC 6749#22
swalker326 merged 4 commits intomasterfrom
fix/implicit-flow-rfc-6749-compliance

Conversation

@swalker326
Copy link
Copy Markdown

@swalker326 swalker326 commented Mar 19, 2026

Summary

  • port the upstream implicit-flow compliance fix from fix(issuer): ensure implicit flow complies with RFC 6749 Section 4.2.2 anomalyco/openauth#304 into our fork
  • stop issuing refresh_token values for response_type=token and include token_type=Bearer plus expires_in in the fragment response
  • add issuer coverage that validates the implicit-flow response shape and confirms the change works with our current token generation path
  • include our local upstream priority tracker for follow-up cherry-picks

Validation

  • bun test packages/openauth/test/issuer.test.ts
  • bun run --filter "@kagii/openauth" typecheck
  • bun run --filter "@kagii/openauth" check

Platform fit

  • this change is isolated to the implicit flow branch in issuer() and reuses the existing generateRefreshToken: false option already supported by our fork
  • code flow, refresh-token flow, and client-credentials behavior stay unchanged

Credit

Copy link
Copy Markdown

@shpaw415 shpaw415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduce a fix the of the malformed flow, displayed in the RFC 6749.
I reviewd:

  1. RFC 6749 Compliance
    The implementation perfectly aligns with Section 4.2.2 of the spec. Specifically, removing the refresh_token from the response_type=token flow is a key security correction. Including token_type=Bearer and expires_in in the URI fragment ensures we are now fully compliant with standard expectations for implicit grants.

  2. Test Coverage & Validation
    I've reviewed the changes in packages/openauth/test/issuer.test.ts. The new test cases effectively validate the shape of the fragment response and is specific of the assigned token flow.

Approved!

@swalker326 swalker326 merged commit 311ea74 into master Mar 21, 2026
2 checks passed
@swalker326 swalker326 deleted the fix/implicit-flow-rfc-6749-compliance branch March 21, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants