Add workflow YAML loader with $extends and ${{ }} expressions#316
Draft
em3s wants to merge 1 commit into
Draft
Conversation
Implements the parser layer of the workflow DSL (#310). Workflow YAML binds onto Workflow + JobSpec case classes via Jackson, with $extends deep-merge and ${{ env / presets / load }} expressions resolved at load time. needs.* expressions and 'when:' operator forms are deferred to runtime (handled by the EmbeddedRunner in a follow-up PR). - Workflow + JobSpec (kind / artifact / mainClass / args / submit / run / needs / when) - WorkflowLoader: YAML -> raw map -> resolve presets -> resolve \$extends -> resolve expressions (lenient on needs) -> Jackson bind - Expression evaluator: env / presets / needs / load - ExtendsResolver: deep merge with cycle protection - Tests + sample YAMLs (spark-pi.yaml, extends-via-load.yaml) Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <[email protected]> Co-Authored-By: Happy <[email protected]>
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the parser layer of the workflow DSL (#310). YAML binds onto case classes via Jackson, with
$extendsdeep-merge and${{ ... }}expressions (env / presets / load) resolved at load time.needs.*andwhen:operator forms are preserved for runtime evaluation in a follow-up PR (EmbeddedRunner).Stacked on #314 (Step DSL) — review/merge that first.
Changes
Workflow+JobSpecdata classes (newkind/artifact/mainClass/args/submit/run/needs/whenshape)WorkflowLoader— YAML → resolved tree →WorkflowExtendsResolver— deep merge, cycle protection,$prefix as processor directiveExpression—env.X,presets.X,needs.X.{result,outputs.Y},load('path'); lenient mode for deferred resolutionHow to Test
AI Assistance