[codex] Refine TBC Holy Priest rotation#7
Open
gnummers wants to merge 3 commits into
Open
Conversation
…opilot <223556219+Copilot@users.noreply.github.com>
# Conflicts: # MaxDps_Priest.toc # Specialization/TBC/Discipline.lua # Specialization/TBC/Holy.lua # Specialization/TBC/Shadow.lua
Collaborator
|
I see several bits of unessesary changes that make going through this just a pain please fix. |
doadin
reviewed
May 26, 2026
| function Discipline:AoE() | ||
| if (MaxDps:CheckSpellUsable(classtable.HolyNova, 'HolyNova')) and cooldown[classtable.HolyNova].ready then | ||
| if not setSpell then setSpell = classtable.HolyNova end | ||
| if not Discipline.classtable then Discipline.classtable = MaxDps.SpellTable or {} end |
Collaborator
There was a problem hiding this comment.
all of this is just not needed. and makes the code less readable.
doadin
reviewed
May 26, 2026
Collaborator
There was a problem hiding this comment.
looks like the only change in this file that actually does anything is the spellid changes. to which only 1 changed. one number change not 25 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary:
Impact: