rpython: complete the eval_ast merge, add DEBUG-EVAL #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asarhaddon
force-pushed
the
rpython
branch
4 times, most recently
from
13abb6d to
c650079
Compare
Commit 0338927 had only updated stepA.
|
@asarhaddon One thing I noticed with this change is that it's 30-40% slower on the perf3 benchmark than it was before (it's notable because rpython was the clear leader before on perf3 and now it's second behind Java). It appears to be specifically the DEBUG-EVAL check. Just something interesting to note. |
29 tasks
|
The cause is probably that the DEBUG-EVAL string is wrapped into a MAL symbol on each evaluation, then unwrapped repeatedly in each outer environment. The same issue affects a lot of implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.