Skip to content

Conversation

@gzzhanghao
Copy link

This PR aims to fix the same issue with #714

The issue still exists after setting preserveLineBreaks option.

<script>//
<% ... %>
</script>

Expected:

<script>
<% ... %>
</script>

Actual:

<script></script>

@alexlamsl
Copy link
Collaborator

alexlamsl commented Sep 21, 2016

Looking at that regex, cases like <script>\n\t<% ... %></script> might not be covered...?

Edit: never mind, I see how this can work just fine.

@alexlamsl
Copy link
Collaborator

As stated in #716, I think we should just aim to tackle the larger issue of having custom fragments in all sorts of locations within scripts and stylesheets, either by default or using custom processors.

@gzzhanghao
Copy link
Author

Fixed in #720

@gzzhanghao gzzhanghao closed this Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants