[dotfiles-improvement] fix: add command -v happy guard to claude() default-mode branch - #529
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
The claude() function calls `happy` in its default-mode branch without checking whether the binary exists. If `happy` is not installed the user sees a raw 'command not found: happy' error with no guidance. Apply the same guard pattern already used in c() and claude-review() in misc.zsh: check for either `happy` or the external `claude` binary via `whence -p`, and emit the standard install hint on failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
claude()function inzsh/aliases/claude-copilot.zshcallshappyin itsdefaultmode branch without checking whether the binary exists. Ifhappyis not installed, the user gets a rawcommand not found: happyerror with no actionable guidance.Change
Add the same guard pattern already used by
c()andclaude-review()inmisc.zsh:This checks for either the
happybinary or the externalclaudebinary (viawhence -p, which searches PATH only, not shell functions) before attempting to invokehappy.No behavior change when tools are present