[dotfiles-improvement] perf: replace echo|wc -l|tr with ZSH native line counting in ROSA functions - #539
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…ctions
Replace $(echo "$clusters" | wc -l | tr -d ' ') with ${#${(f)clusters}}
in select-rosa-cluster.zsh and use-rosa-sts.zsh.
The (f) parameter flag splits on newlines and ${#} counts elements,
avoiding two subshell forks (wc + tr) per call.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace two instances of
$(echo "$clusters" | wc -l | tr -d ' ')with the ZSH-native${#${(f)clusters}}in the ROSA cluster functions.What
echo "$clusters" | wc -l | tr -d ' 'forks two subprocesses (wc+tr) just to count the number of lines in a string.ZSH has a built-in idiom that does this without any forks:
(f)splits the string on newlines${#...}counts the resulting elementsAffected files
zsh/functions/openshift/rosa/select-rosa-cluster.zsh— line 39zsh/functions/openshift/rosa/use-rosa-sts.zsh— line 50No behavior change
The
(f)splitting +${#}count produces the same integer result aswc -l. Thetr -d ' 'was only needed to strip whitespace thatwcadds on macOS — not needed with the ZSH native approach.