Skip to content

[dotfiles-improvement] perf: replace grep|cut router IP chain with ZSH parameter expansion in macos-notvscode.zsh #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[dotfiles-improvement] perf: replace grep|cut router IP chain with ZSH parameter expansion in macos-notvscode.zsh #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions zsh/macos-notvscode.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ set-tf-proxy(){
return 1
fi
local _router_ip
_router_ip=$(networksetup -getinfo Wi-Fi | grep -e "^Router" | cut -d " " -f 2)
_router_ip=${${$(networksetup -getinfo Wi-Fi | grep -e "^Router")}##* }
if [[ -z "$_router_ip" ]]; then
echo "Error: Could not determine Wi-Fi router IP" >&2
return 1
Expand Down Expand Up @@ -76,7 +76,7 @@ set-socks-proxy(){
export SOCKS_ROUTER_IP="$1"
else
local _router_ip
_router_ip=$(networksetup -getinfo Wi-Fi | grep -e "^Router" | cut -d " " -f 2)
_router_ip=${${$(networksetup -getinfo Wi-Fi | grep -e "^Router")}##* }
if [[ -z "$_router_ip" ]]; then
echo "Error: Could not determine Wi-Fi router IP" >&2
return 1
Expand All @@ -103,7 +103,7 @@ get-socks-proxy(){
fi
local router_ip="${SOCKS_ROUTER_IP}"
if [[ -z "$router_ip" ]]; then
router_ip=$(networksetup -getinfo Wi-Fi | grep -e "^Router" | cut -d " " -f 2)
router_ip=${${$(networksetup -getinfo Wi-Fi | grep -e "^Router")}##* }
fi
local proxy_port="${SOCKS_ROUTER_PROXY_PORT:-1888}"

Expand Down