[dotfiles-improvement] perf: replace $(date '+%H:%M:%S') with ZSH \$\{(%):-%D{}} in util.zsh - #557
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
Replace two $(date '+%H:%M:%S') subshell calls in wait-for-url with
the ZSH-native ${(%):-%D{%H:%M:%S}} prompt expansion.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace two
$(date '+%H:%M:%S')subshell calls inwait-for-url(util.zsh) with the ZSH-native${(%):-%D{%H:%M:%S}}prompt expansion.Changes
zsh/util.zsh(×2)$(date '+%H:%M:%S')${(%):-%D{%H:%M:%S}}Why
${(%):-%D{format}}is the ZSH-native way to format a timestamp:(%)enables prompt-style expansion%D{format}invokesstrftimeinternally — no subshell, nodate(1)forkSame technique as the existing open PR #537 for other files.
No behavior change
The
%H:%M:%Sformat specifiers are identical betweendate(1)and ZSH'sstrftime.