Fix/ci all checks#223
Open
fredericklamar342-prog wants to merge 12 commits into
Open
Conversation
added 7 commits
June 28, 2026 17:23
The endpoint was implemented in OrderService.getTransitions() and the repo layer but was never wired up in the Express router. This caused two CI test failures in order-transitions.test.ts with 404 responses. Route is placed before the generic GET /orders/:id handler to ensure Express matches the more-specific path first.
|
Someone is attempting to deploy a commit to the karagoz's projects Team on Vercel. A member of the Team first needs to authorize it. |
added 5 commits
July 7, 2026 22:52
soroban-env-host 22.1.3 (pinned by soroban-sdk 22.0.11) uses ed25519-dalek 3.0.0 + rand_core 0.10.1. On Rust >= 1.82 the rand_core 0.10 CryptoRng trait bound changed, breaking the SigningKey::generate signature with: error[E0277]: the trait bound \&mut R: rand::CryptoRng\ is not satisfied Fixes: - Add soroban/rust-toolchain.toml pinned to 1.81.0 - Update CI to use dtolnay/rust-toolchain@master with explicit toolchain=1.81.0 so the pin takes effect on the runner - Revert workspace soroban-sdk back to 22.0.11 (no patch needed)
soroban-env-host 22.1.3 resolves ed25519-dalek to 3.0.0 by default, which pulls in rand_core 0.10.1. On stable Rust, this causes a trait bound mismatch (error[E0277]: the trait bound \&mut R: rand::CryptoRng\ is not satisfied). Downgrading ed25519-dalek to 2.2.0 entirely eliminates rand_core 0.10.1 from the tree. Since Cargo.lock was previously gitignored, CI was ignoring our downgrades and resolving dependencies fresh to the broken 3.0.0. Committing Cargo.lock fixes this and guarantees reproducible builds for the contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #52
What & Why
One or two paragraph summary of the change and the problem it solves. Link the issue with
Closes #…orRefs #….Touched surface
Tick every layer this PR changes:
frontend/— React + Vite bridge UIpackages/sdk/— shared TypeScript SDKcoordinator/— order book + REST/WS serviceresolver/— community resolver runnerrelayer/— legacy v1 listener / watchdog (changes here need extra scrutiny)contracts/— Solidity v2 (HTLCEscrow,ResolverRegistry)soroban/— Stellar Soroban contracts (oversync-htlc,oversync-resolver-registry)docs/— documentation only.github/workflows/,docker,env.example)Settlement & refund semantics
Critical for SCF / investor review. If any box is checked, the PR must also update
docs/REVIEW_RESPONSE.mdand link the updated section in the PR description.