Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localization files for English and Chinese #170

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

samzong
Copy link
Member

@samzong samzong commented Jan 19, 2025

…ology and improve translations for dashboard UI elements.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Update localization files for English and Chinese: standardize terminology and improve translations for dashboard UI elements.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 19, 2025
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2025
@samzong samzong changed the title Update localization files for English and Chinese: standardize termin… Update localization files for English and Chinese Jan 19, 2025
…ology and improve translations for dashboard UI elements.

Signed-off-by: samzong <[email protected]>
@samzong
Copy link
Member Author

samzong commented Jan 19, 2025

@warjiang @RainbowMango

@warjiang
Copy link
Contributor

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
/lgtm

/hold
wait for #172

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2025
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@warjiang
Copy link
Contributor

Looks great! /lgtm

/hold wait for #172

#172 has already been merged, should we move forward?

@RainbowMango
Copy link
Member

/hold cancel

/approve

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@karmada-bot karmada-bot merged commit df19447 into karmada-io:main Jan 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants