-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Makefile, make development simpler #171
Conversation
/assign |
@warjiang updated, thanks for u review,
|
@samzong only two problems left, thanks for your patience ~ |
btw, the |
|
Signed-off-by: samzong <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bin-karmada-dashboard-web: | ||
BUILD_PLATFORMS=$(GOOS)/$(GOARCH) hack/build.sh karmada-dashboard-web | ||
image-karmada-dashboard-web: | ||
BUILD_PLATFORMS=linux/$(GOARCH) hack/build.sh karmada-dashboard-web | ||
cp -R ui/apps/dashboard/dist _output/bin/linux/$(GOARCH)/dist | ||
DOCKER_FILE="build-web.Dockerfile" VERSION=$(VERSION) REGISTRY=$(REGISTRY) BUILD_PLATFORMS=linux/$(GOARCH) hack/docker.sh karmada-dashboard-web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks the CI workflow:
make bin-***-dashboard-web
shell: /usr/bin/bash -e {0}
env:
IMAGE_NAME: ***/***-dashboard-web
BINARY_NAME: ***-dashboard-web
make: *** No rule to make target 'bin-***-dashboard-web'. Stop.
Error: Process completed with exit code 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll send a PR to fix it.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
It is inconvenient to start the development environment locally.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: