Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update licence comment #177

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
index.html should be commented in form of <!-- content -->
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 22, 2025
@karmada-bot karmada-bot requested review from jhnine and samzong January 22, 2025 06:28
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
@warjiang
Copy link
Contributor Author

/assign @RainbowMango

@RainbowMango
Copy link
Member

LGTM

Just out of curiosity, what's the impact?

@RainbowMango
Copy link
Member

cc @chaosi-zju

@chaosi-zju
Copy link
Member

It does need to be modified, /**/ is not the HTML comment format and the impact is those lines will be parsed as plain text.

@warjiang
Copy link
Contributor Author

Just out of curiosity, what's the impact?

code like <-- xx --> will display directly in your browser

@chaosi-zju
Copy link
Member

I will re-check the files to see if there are any other non .go files with this issue.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@karmada-bot karmada-bot merged commit c08f8a0 into karmada-io:main Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants