Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format code about exported function should have comment #179

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Jan 23, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

format code about exported function should have comment

Which issue(s) this PR fixes:

Fixes part of #6078

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 23, 2025
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2025
@warjiang
Copy link
Contributor

/assign

@chaosi-zju
Copy link
Member Author

@RainbowMango

What do you think of the fix method in this PR?

here may still about 60+ place this kind lint error, shall I move forward to handle the rest?

cmd/api/app/router/setup.go Outdated Show resolved Hide resolved
cmd/api/app/router/setup.go Outdated Show resolved Hide resolved
@warjiang
Copy link
Contributor

@RainbowMango

What do you think of the fix method in this PR?

here may still about 60+ place this kind lint error, shall I move forward to handle the rest?

@chaosi-zju the work is valuable for me. In this PR, exported rule under the revive linter indicate me that if I want to export something, I should make some comments, and that push me to think about the question, does it really need to export the struct or the function.

I think we should still move forward to fix kind of errors reported by revive.

@chaosi-zju
Copy link
Member Author

I think we should still move forward to fix kind of errors reported by revive.

comments fixed, we can handle this PR first, I will submit another PR to handle the rest
a PR too large may complicates review

@warjiang
Copy link
Contributor

I think we should still move forward to fix kind of errors reported by revive.

comments fixed, we can handle this PR first, I will submit another PR to handle the rest a PR too large may complicates review

+1

@warjiang
Copy link
Contributor

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2025
@karmada-bot karmada-bot merged commit 5648666 into karmada-io:main Jan 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants