-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format code about exported function should have comment #179
Conversation
/assign |
What do you think of the fix method in this PR? here may still about 60+ place this kind lint error, shall I move forward to handle the rest? |
@chaosi-zju the work is valuable for me. In this PR, I think we should still move forward to fix kind of errors reported by |
548342a
to
621715d
Compare
comments fixed, we can handle this PR first, I will submit another PR to handle the rest |
Signed-off-by: chaosi-zju <[email protected]>
621715d
to
4944dcb
Compare
+1 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
format code about exported function should have comment
Which issue(s) this PR fixes:
Fixes part of #6078
Special notes for your reviewer:
Does this PR introduce a user-facing change?: