Skip to content

Karmada client integration k8s #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MdSayemkhan
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #214

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

just a trial for the integration

@karmada-bot karmada-bot requested review from samzong and warjiang May 26, 2025 04:19
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2025
'(?:169\\.254|192\\.168)(?:\\.\\d{1,3}){2})(?!172\\.(?:1[6-9]|2\\d|3[0-1])(?:\\.\\d{1' +
',3}){2})(?:[1-9]\\d?|1\\d\\d|2[01]\\d|22[0-3])(?:\\.(?:1?\\d{1,2}|2[0-4]\\d|25[0-5])' +
'){2}(?:\\.(?:[1-9]\\d?|1\\d\\d|2[0-4]\\d|25[0-4]))|(?:(?:[a-z\\u00a1-\\uffff0-9]-*)*' +
'[a-z\\u00a1-\\uffff0-9]+)(?:\\.(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]' +

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'ftp://0.' and containing many repetitions of '00.'.
@MdSayemkhan
Copy link
Contributor Author

/assign @warjiang

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from warjiang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@warjiang
Copy link
Contributor

@MdSayemkhan could you follow the instruction of DCO bot and fix the problem of dco?

@MdSayemkhan MdSayemkhan force-pushed the karmada_client_integration_k8s branch from 70c7477 to 2cdefdc Compare May 26, 2025 12:12
@karmada-bot
Copy link
Collaborator

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the karmada-io org. You can then trigger verification by writing /verify-owners in a comment.

  • zehuaiWANG
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • cmd/modules/web/i18n/zh-Hant-HK/OWNERS
    • cmd/modules/web/i18n/zh-Hant/OWNERS
  • tanjunchen
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • cmd/modules/web/i18n/zh-Hant-HK/OWNERS
    • cmd/modules/web/i18n/zh-Hant/OWNERS
  • chenrui333
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • cmd/modules/web/i18n/zh-Hant-HK/OWNERS
    • cmd/modules/web/i18n/zh-Hant/OWNERS
  • gochist
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • helight
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • cmd/modules/web/i18n/zh-Hant-HK/OWNERS
    • cmd/modules/web/i18n/zh-Hant/OWNERS
  • hwdef
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • cmd/modules/web/i18n/zh-Hant-HK/OWNERS
    • cmd/modules/web/i18n/zh-Hant/OWNERS
  • mkorbi
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • raelga
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • ziyi-xie
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • feloy
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • shu-mutou
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • atoato88
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • seokho-son
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • headcr4sh
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • kgroschoff
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • anyulled
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-owners-file size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration of K8s dashboard
3 participants