Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HA installation with CLI #453

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Add HA installation with CLI #453

merged 1 commit into from
Jan 2, 2024

Conversation

Affan-7
Copy link
Member

@Affan-7 Affan-7 commented Aug 14, 2023 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR introduces a guide for deploying Karmada HA using CLI.

Which issue(s) this PR fixes:
Related to: #418
Task 2 out of 5

Newly added page: https://deploy-preview-453--karmada.netlify.app/docs/next/installation/ha-installation-with-cli

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 14, 2023
@karmada-bot karmada-bot requested review from Poor12 and samzong August 14, 2023 16:54
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2023
@Affan-7
Copy link
Member Author

Affan-7 commented Aug 14, 2023

This documentation explains karmada HA deployment using stacked etcd topology.

I got stuck while deploying karmada HA with external etcd topology. In case of Kubernetes HA we can use Kubeadm to configure an external etcd cluster. But in case of Karmada I don't have an idea, if there is a tool to configure the external etcd cluster, and I don't know any other method for configuring external etcd.

Can someone please provide a method to configure an external etcd for Karmada?

@Affan-7
Copy link
Member Author

Affan-7 commented Aug 14, 2023

/cc RainbowMango

@Affan-7
Copy link
Member Author

Affan-7 commented Aug 15, 2023

Update: I think I have to wait for karmada-io/karmada#3898.

@RainbowMango
Copy link
Member

Yes, exactly.

windsonsea
windsonsea reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent 3 spaces for a 1-2-3 list please.

docs/installation/ha-installation-with-cli.md Show resolved Hide resolved
docs/installation/ha-installation-with-cli.md Show resolved Hide resolved
docs/installation/ha-installation-with-cli.md Outdated Show resolved Hide resolved
@Affan-7 Affan-7 force-pushed the ha-with-cli branch 2 times, most recently from 640bfa6 to aa01d53 Compare December 11, 2023 08:05
@Affan-7
Add HA installation with CLI
a45a74b 
Signed-off-by: Mohammed Affan <[email protected]>
@Affan-7 Affan-7 requested a review from windsonsea December 13, 2023 14:54
RainbowMango
RainbowMango reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

RainbowMango
RainbowMango approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!
Thanks @Affan-7 and sorry for letting this sit.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@karmada-bot karmada-bot merged commit 8c57f2e into karmada-io:main Jan 2, 2024
5 checks passed
@Affan-7 Affan-7 mentioned this pull request Sep 20, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@Poor12 Poor12 Awaiting requested review from Poor12

@samzong samzong Awaiting requested review from samzong

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Affan-7 @RainbowMango @karmada-bot @windsonsea