gptel-transient: Use proper ellipsis for consistent UI #640
Conversation
pabl0
commented
Feb 13, 2025
pabl0
commented
- gptel-transient.el (gptel-option-overlaid): Use a proper ellipsis (…) instead of three ASCII dots (...) when truncating the user instruction, provided Unicode is displayable and `truncate-string-ellipsis' is nil. This change allows for two additional characters and enhances visual appeal and consistency.
gptel-transient.el
Outdated
| @@ -532,7 +532,7 @@ Also format its value in the Transient menu." | |||
| (add-hook 'transient-exit-hook ov-clear-hook))) | |||
| ;; Updating transient menu display | |||
| (if value | |||
| (propertize (concat argument (truncate-string-to-width value 25 nil nil "...")) | |||
| (propertize (concat argument (truncate-string-to-width value 39 nil nil 'ellipsis)) | |||
There was a problem hiding this comment.
Any reason you changed the width to 39?
Also please just use t instead of 'ellipsis. I know gptel uses both t and 'ellipsis across its code for this (mostly t). I plan to switch to just t.
There was a problem hiding this comment.
Any reason you changed the width to 39?
It was explained in commit msg of second version. Basically it uses all available space without making the default transient more wide:
But of course the width depends on other settings as well so 39 feels way too specific. Changed it to 35, or do you think it should be as short as possible? Of course the full directive is visible in the actual buffer as well.
Also please just use
tinstead of'ellipsis. I know gptel uses bothtand'ellipsisacross its code for this (mostlyt). I plan to switch to justt.
Yes I agree it's better, done.
There was a problem hiding this comment.
There is of course transient-force-single-column issue as you mentioned in #630. However the other parts in the transient also need some tweaking to fit into a very narrow side window:
There was a problem hiding this comment.
35 is fine, I'll merge this. But I wonder if it's possible to show the additional instruction on the following line, where it can be wider. I remember trying and failing to do that.
* gptel-transient.el (gptel-option-overlaid): Use a proper ellipsis (…) instead of three ASCII dots (...) when truncating the user instruction, provided Unicode is displayable and `truncate-string-ellipsis' is nil. This change allows for two additional characters and enhances visual appeal and consistency. Also, increase width to 35 to use most available space without making the whole tansient wider. Fix a typo in docstring.
* gptel-transient.el (gptel-option-overlaid): Use a proper ellipsis (…) instead of three ASCII dots (...) when truncating the user instruction, provided Unicode is displayable and `truncate-string-ellipsis' is nil. This change allows for two additional characters and enhances visual appeal and consistency. Also, increase width to 35 to use most available space without making the whole tansient wider. Fix a typo in docstring.
