gptel-transient: Polish gptel--read-with-prefix user experience #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabl0
force-pushed
the
read-with-prefix
branch
from
2151240 to
92a0eed
Compare
|
I made slight refactoring changes (use cl-flet) and fixed a bug related to calling |
* gptel-transient.el (gptel--read-with-prefix-help): Turn into a function to show one function. (gptel--read-with-prefix): Enable resizing minibuffer (to make cycling the ov meaningful). Drop `make-separator-line' which is buggy. Move the prompt to the last line, which looks better and avoids cursor jumping. Use `window-max-chars-per-line' instead of `window-width' (which is incorrect in terminal). Replace newlines with return symbol. Calculate the multi-line layoyt correctly to use all available space on the last line. Cycle between just two modes: one line and multiple lines (hiding one line does not add much value). Don't show the TAB help if the whole prefix fits into one line. (gptel--infix-add-directive): Use simple prompt. * gptel-rewrite.el (gptel--infix-rewrite-extra): Use simple prompt. Replace RETURN LEFT (U+2C90) with smaller RETURN SYMBOL (U+23CE), which looks more readable (with many typefaces) between two pieces of text.
|
Have you had the opportunity to review this? I find the current implementation a bit clumsy, and this took unexpectedly significant effort to achieve. :-) |
|
Not yet, as it looks pretty involved. I will get to this, I'm busy writing the gptel manual at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gptel-transient.el (gptel--read-with-prefix-help): Turn into a function to show one function.
(gptel--read-with-prefix): Enable resizing minibuffer (to make cycling the ov meaningful). Drop
make-separator-line' which is buggy. Move the prompt to the last line, which looks better and avoids cursor jumping. Usewindow-max-chars-per-line' instead of `window-width' (which is incorrect in terminal). Replace newlines with return symbol. Calculate the multi-line layoyt correctly to use all available space on the last line. Cycle between just two modes: one line and multiple lines (hiding one line does not add much value). Don't show the TAB help if the whole prefix fits into one line. (gptel--infix-add-directive): Use simple prompt.gptel-rewrite.el (gptel--infix-rewrite-extra): Use simple prompt.
Replace RETURN LEFT (U+2C90) with smaller RETURN SYMBOL (U+23CE), which looks more readable (with many typefaces) between two pieces of text.